I made the Linux-Mac switch in 2004 or so, and currently use my Mac to manage Linux boxes and develop. And I can say some things about your plan:

The Bad:

1. I have a relative who just recently became a real Tico, and I can say that if you use an "Apple ID" to do anything on "the iTunes/App store", it probably will screw things up or not work, because if Apple doesn't have a store presence in your country, Credit Card processing may not work at all. My relative had their iPad locked remotely because they tried to use their credit card to buy apps. (this is second-hand information, but you should be forewarned)
2. If your mac breaks, and you don't have a US-based "mule" to handle repair shipments, you're similarly fucked. If Apple doesn't have a store in your area they consider your having bought a product to be Highly Suspect. (again, my relative had issues with her iPad. Also, and totally unrelated, why the fuck can't you buy Cheddar Cheese in South America. How do you people live like that?)
3. If you develop stuff or use git in ways that absolutely require you to have case-sensitive filesystems, then you're going to have to do weird things like have / be on one partition, then add another partition that gets mounted at /Volumes/OtherCaseSensitivePartition and do all your work there, perhaps with a symlink from /Users/letsencrypt/Documents/ -> /Volumes/OtherCaseSensitivePartition/Documents

The Good:

1. Others have said, and it's true: iTerm2 is the best terminal emulator in the world, and every terminal emulator on Linux is complete shit compared to it. This includes rxvt, Gnome terminal, and yes, Terminator.
2. SIP won't affect you one bit. Unless your tools are completely stupid and do things like #!/usr/bin/bash instead of #!/usr/bin/env bash (the thing I found that does this is ruby stuff, which is absolutely SHOCKED to find that it can't just write to /usr/bin/sass. Fuck you, rubygems.) SIP is great. I wish Linux did that, and, in a way, with containers, it already does. Complaining that root isn't really root is like complaining that your docker instance isn't running on bare metal. Root is root, and you don't need to write to /bin, like, ever.
3. You can install homebrew, and get all the GNU stuff you expect, and it all works great and I've never had a problem (fuck you, rubygems, you suck).
4. The programs that people write for the mac are just easier to use. This may not affect you if you're the kind of person who thinks that GIMP is an easy-to-use program.

The Ugly:

1. If you're not the kind of person who cares how a program looks, or how easy a program is to use, then you won't notice the good. You won't notice iTerm2. All you'll see are the walls they put up between Total Control of Every Last Byte and Normal Users' Fuckups.
2. HFS+ isn't much worse than Ext3. But it's nowhere near as good as XFS. (I guess Ext4, too, kind of, but I'm an XFS guy). They all have failure modes. In 20 years of using linux 10 of using OS X, I've had no more filesystem failures (corrupt files, fscks-gone-wrong) on HFS+ than I have on Ext2/3/4.
3. If you want to upgrade your hardware, you don't want a Macbook Pro. You still want a ThinkPad. (I've owned many Thinkpads, and my Macbook Pro has been more reliable, but the new ones are all soldered-on-RAM, and that makes me angry as well)

In short: based on where you live, and how you feel about "Human Interface Guidelines", no. You should not buy a mac. You should buy whatever "PC" is sold with in-country support, and you should keep running Linux. The Mac will only make you mad. Not because it's worse, but because the things it does better don't concern you.