First off, the "identity crisis" doesn't really matter as long as we're still effective, which we are. We could sent a single division and few special attached units and topple a nation within weeks if we had to.
Part of the problem is that there isn't really loads of Army-wide espirit de corps because there's been "corporatization" going on. Lot of bureaucratic bullshit, PR bullshit, and a lot of what the Army really is tends to come off as disingenuous. Online trainings, an endless list of quarterly checked boxes, super-hooah (read: retarded) US ArmyTM stuff, we were rolling around in an illogical UCP uniform for nearly at least a decade, and also the fact that we now look like bus drivers in our dress uniforms. We don't take care of tradition like we should, we just keep changing stuff until something sticks.
Then you gotta add in the lack of exclusivity, which is a component of pride. The Army is huge. Straight up, we're massive. Soldiers generally take more pride in their divisions, since that's smaller scale. I mean, it's no secret that we sing more about the Screaming Eagles, the 82nd, and 10th Mountain than we do about our cannonball seal or Army star thing. We don't have as strong an overarching identity as, say, the Marine Corps with the EGA and so on. They're smaller, so they can have a more unified identity. We're bigger, so we usually place more emphasis on what division patch we wear on our shoulder. This isn't a bad thing. I think it's something we should encourage more actually, both in culture and in how we utilize our divisions. It's a real shame that the 10th Mountain is technically just standard infantry now and not something cooler like "mountain infantry". Even if it doesn't make sense, I feel like it would do overall culture of the Army a lot if we encouraged each large sect of the Army into it's own niche, kind of like it already is, but maybe we can do more. I dunno. It's one thing to say you're a soldier, but most people take more pride in their smaller communities within the Army.
Then there is the fact that reservists and National Guardsmen live functionally different lives than most active duty soldiers, compose at least half our overall force strength, and wear the exact same uniforms. I'm throwing zero shade at reservists and guard, but it doesn't make sense how we utilize them. It makes no sense to me how active duty soldiers can join, stay in one job, and deploy zero, while you have people in the guard carrying 5 MOS, deployed 3 times, and still only train twice a month. I would say this isn't a problem... but there have been issues in the past, not just in the Army with the way we mobilize service members who aren't full time military. I feel like there should be more to distinguish reservists from Guard and both from active. They're different worlds, both serving important functions, that shouldn't be blended into the same thing (kinda like how different the Coast Guard is from the Navy). That's never really made sense to me, it's just something I've accepted at this point.
I also think there is an issue with how we do promotions and stuff. You know how you shouldn't fuck with something that isn't broken? That isn't really adhered to by a lot of leadership. The good idea fairy always comes in full force to screw up things that didn't need to be fixed for the sake of a bullet point on an NCOER or an OER or whatever the fuck. The system we have essentially incentivizes unnecessary change rather than maintaining working tradition. Change can be good, sometimes it is, but the Army has been around for a long time and usually shit just gets fucked up when you screw it around so you can say you did something during your command of a unit.