I like the game much more so far than I thought and I kind of feel like I should get BFA even as shadowlands is right around the corner. I wouldn’t mind getting my hands on some war fronts or leveling azerite gear or those type of things while everyone else is doing it too.

Straight from your own words. this should give you the answer you are wanting to hear. but don't do things just because others are doing it. Do it because you want to.

I made a new account 5, 6 months ago and lost access to my old account that was from vanilla and up, honestly I ended up buying bfa because I really enjoy some of the content in it and if I enjoy something then I of course want to own it.

Yes SL may be a few more months away but that gives you a few more months to hit 120, get your legacy cloak and do visions and get the mailmuncher mount since its going away in SL and you can farm gold and stuff for SL so you won't be fully broke. You can also spend time farming for tmogs, etc, dive into some mythics and get your feet wet in mythic plus's. I personally don't like any above 10 and when you get there you will see why.

hell if you're on the horde side and usa servers I could even run you through some bfa dungeons on normal for gear etc and run you through some mythic 0's thru 9's with a group to get you semi geared if that is your thing.