Robert Hallock: GPUOpen is AMD’s Long-Term Open Source Strategy

Have you looked at your PR? You talk about you don't have the time to 'read documentation' on the technology you're trying to push changes to? But you expect the maintainers to wade through that disgusting PR? It looks like you've just loaded the code into your IDE and auto formatted it to your preference, as if you know best, maybe you think you do.

You made changes to perfectly valid C code, for no reason what so ever, aside from your egotistical formatting. Then you have the nerve to complain about OpenCL kernel code claiming C compliance.

Replacing spaces with tabs is hardly fixing 'bad code', I don't think I've ever worked anywhere that used tabs to indent. Anyone who's bothered to read how to contribute to any project knows you match the formatting scheme of the existing code, even if it hurts your feelings.

After wading through your white-space changes and comment deletions I've given up looking for any actual code changes.

Don't take the failed PR to heart, I'm sure most of us have been there when we were young and eager and much too enthusiastic to read documentation. You learn from it, and take your time and do it right next time. To be honest the dev who refused your changes was polite and did explain why.

Would you want to review a 9000+ line PR? How would you be sure one of those lines didn't introduce a major bug? After a few hundred lines of changes people tend to get bored and that's how crap code and bugs get into an otherwise stable codebase.

You need to learn to use your tools, your biggest mistake was letting your editor format every file you touched. Your PR was titled "Fixing build warnings", formatting code is outside the scope of this.

Read the contributing readme, the owner didn't write it for fun, it will have important information, like what branch to make a PR against. It also says "code submissions should not mix styles within an individual file" which as established was your biggest mistake.

Don't waste other peoples time, these people are busy and their time is precious to them, consider how much of their time you're wasting when you expect them to review thousands of lines of nothingness.

/r/Amd Thread Parent Link - xda-developers.com