In life, she was probably a pretty awesome person, you don't get to be Ranger General of the High Elves from being half arsed and uncaring. In death though, she hasn't done much good for anyone, unless you're one of the Forsaken, in which case she's probably the best thing that's ever happened to you. Obviously it's all from the perspective of which Forsaken you ask, but the majority totally adore her, and she's earned it. She's also earned the scorn of everyone that hates/dislikes her, even if they've never met her before or know very little about her, she's still done things to validate how they feel.

These days though, I'm not really sure if being Forsaken matters as much to her as it used to. Their numbers have swelled and she's swinging them about a lot, combined with all she has at her disposal now (plague, val'kyr, probably the second largest army on Azeroth, personal power, etc), she's on a total power trip. Although I'm still of the opinion the Forsaken and the Horde are her top priorities, it doesn't seem like she "cares" as much as she used to.