Lawyer here, but this isn’t my specific area of expertise, so I can only speak generally. The crimes that trump likely committed would be part and parcel to the same laundry list of crimes already found by guilty verdict or guilty plea on the part of many of his closest associates, if not committed by his own hand then by the rules of agency (if my boss had me kill his wife and I do so, we’re both being hanged) or as a co-conspirator. All that is needed is one guilty party like Cohen and Manafort to flip and provide sufficient evidence of Trump’s involvement. As long as he played a material part in any of the numerous activities already pled to by his employees which constitute those crimes, Trump has committed a crime. And judging by cohen’s and manafort’s dirt they likely have and might use, I would think twice about any confidence whatsoever that trump will be coming out of this intact.

And yes, the issue isn’t whether trump himself can be indicted for those crimes. The mueller team isn’t even disputing that anyway, a question that the Supreme Court would have to decide, but they do everything they can to avoid that sort of thing, but that’s not really the issue.

The issue is impeachment. When you add in the porn star and Russian stuff, especially if any red-hot audio or video tape come out, It might happen sooner rather than later. If it comes out a decent amount of time before the next election and is inflammatory enough, it might swing popular opinion hard enough in purple states that some republicans looking to hop on the bandwagon might support impeachment. But it’s only a matter of time. If history is any indicator, the minority party usually takes back power in the next midterms, so the Democrats will have already won back the majority and they will impeach at that point.