3. Sunwell Core released to the public

Sunwell Core released to the public

Sure, let's begin, shall we?

Here's 30 minutes worth of basic random code review:

  • WorldSocket::HandleAuthSession Single threaded authentication, welcome to network blocking hell.
  • Still using ACE for networking, not using boost AT ALL ANYWHERE.
  • http://i.imgur.com/jWk2Ajv.png Really? Breaking if an opcode took more than 3 ms? I bet the response time is a nightmare there. How many cycles would you skip under worst-case complexity just to cast a single spell? 5? 10? Lol. God forbid if the cpu cache flushed while processing opcodes
  • http://i.imgur.com/6fpJWOP.png Cute, no warden at all for OSX, Let just send a simple packet edit to bypass your entire anticheat.
  • http://i.imgur.com/8aamcfy.png Is this some crazy ridiculous attempt at idle disconnections?
  • You've some how managed to add many more locks to an already lock-heavy program, congratulations.
  • http://i.imgur.com/vkY9gEz.png Called your own core shit, nice.
  • http://i.imgur.com/lVpsqJ0.png You have got to be joking me. Hacks, shit readability, shit maintainability. This file contains much more than that as well.
  • http://i.imgur.com/my26yEy.png So let me get this straight, you insert into a basic stl list with manual locking (hello locked queue, what are you??), then you proceed to iterate that locked list http://i.imgur.com/QrWE8cR.png to insert into another stl list, to then process here http://i.imgur.com/Kfm8Wx9.png, which is not a thread safe operation (because you are still running Map::Update while accessing the player in the AH thread, creating data races).

I have no problem with you or sunwell, but when people give you guys so much praise and i can find numerous problems in 30 minutes it saddens me.

/r/wowservers Thread Parent Link - sunwell.pl
Previous
Next

Recently removed from /r/wowservers

What's a good wow server for someone new to the game? Standouts of Each Expansion [Looking for server] My friend and I were looking to roll characters on classic when it drops, but don't want to spend $15/mo on single game. Best Pservers? Which server has gotten the closest to emulating the Blizzard experience? (Any expansion) First Week LH Drama Recap Info about instant 80 "Memories" Official Classic Forums Now Online Played Warmane/Medivh a few weeks ago and had some concerns. Has there been recent improvements? I hate to say it, but Legacy isn't a good idea even now all of the shills are trying to convince gummy to hand over his code so that they may use it to improve their shitty p2w servers LUL Is non-retail wow recommended for a mostly solo/casual player? YHOOL 1% soon to be released (permadeath server) Just won $1800 Just won $1800 Elysium recent action against gold sellers

More Random Comments

I bought this game 2 hours ago and I'm still unable to play Iraq Arrests ISIL's US, Israeli Military Advisors in Mosul Why are men's sexual needs always put on the back burner?! Hibernian Blood Convinced a former peasant to convert instead of buying a new console. He said he could spend between 6-700 dollars and he's ok with the MIBs. How'd I do? Reddit is like the back of the classroom in high school. You can barely hear the serious conversation the OP tried to start because the top comments are all in-jokes. MY [26] girlfriend [24F] of 1.5 years is depressed, help me help her? I am a current Comcast employee.... [WP] As a young child you made an innocent wish to be granted a power that in hindsight was just whimsical and silly. Now you have grown up but you still have the power - how do you use it now as an adult? What is something about you that doesn't come up in normal conversation? I need high-level help with Orianna As someone with braces, I get this a lot Gabe Newell on Source 2: "If other engine manufacturers see stuff in it that's useful to them, well they can integrate it into their engines as well" This is the punishment that a 6 year old boy in Oregon received for being late after his mother's car wouldn't start. Will VR arcades become a thing?