Of the studies in that link the one that shows a higher suicide rate is the only long term study. So surveys taken right after hormone therapy and other opt-in short term surveys are simply not as credible as long term mortality observations. Those are not based on someone's response, those are based on whether they are alive or not and if they had attempted suicide as a matter of fact, not opinion.

“The overall mortality for sex-reassigned persons was higher during follow-up (aHR 2.8; 95% CI 1.8–4.3) than for controls of the same birth sex, particularly death from suicide (aHR 19.1; 95% CI 5.8–62.9). Sex-reassigned persons also had an increased risk for suicide attempts (aHR 4.9; 95% CI 2.9–8.5) and psychiatric inpatient care (aHR 2.8; 95% CI 2.0–3.9).”

Here is a good exploration of this data: https://archive.is/iSsgs

Regardless of whether it's higher before or after, trans suicide rate is much higher than normal. You can blame this on society the same way some people blame higher incarceration rates among AAs on prejudice, however AAs are still 7-8 times more likely to commit homicide in the US compared to whites. Basically the "blame society" argument has its limits and at some point we have to ask if there's something else going on, like the uncomfortable but obvious conclusions which are drawn by the data. Transexuals are less happy than normal people in general, because they are not happy with who they are. Very simple. Calling it a mental disorder isn't wrong, just some refute that assessment because of it doesn't seem nice. Diagnosing someone with autism isn't a matter of "nice" - it's a diagnosis. Transsexualism is the same way, so whether you agree that it's a mental disorder or not is irrelevant. It's not normal. I'm not saying that it makes them a bad person, that they are going to hell or anything along those lines. Just that transsexualism is mental, and it's out of norm, or order. Hence it's a mental disorder. With some very hefty negative implications about that person's quality of life. Playing with words and how to classify transsexualism doesn't change this.