NTA

You told him up-front that you'd lend him the 2nd controller occasionally but that he'd eventually have to buy his own second controller. He pretended he would but then never did because it was easier mooching off you.

As soon as his main controller breaks, oh look, he suddenly finds a way to buy a new controller. So clearly he could have bought another controller that whole time but he didn't until he absolutely had to because it was his main controller.

He can buy himself a second controller if he wants to play with his friends or his girlfriend. Or he can tell them to buy themselves a controller if they want to keep coming over to play with him. It's not your job to provide him with the means to play. He's a big boy.