I've proven that he didn't turn a profit on the attack
Be that as it may, you are extremely wrong in your assessment of Mr. Silverstein's situation:
He had good reason to expect a literal profit
He still profited overall
The new WTC is worth more than the old one. Who cares if the insurance didn't cover it entirely? He is better off than he was before.
One World Trade Center, the tallest tower, is being paid for partly by a portion of Silverstein Properties insurance settlement that under the 2005 Master Agreement, he had to hand over to the Port Authority, which owns the site. One WTC is also being financed by the issuance of Liberty Bonds, which were created for the purpose of rebuilding downtown. Investors buy them, therefore providing capital for the project and they are paid back over time with interest. The PA has also gotten a private investor, Durst Companies, to buy an interest in the building for $100 million.
The Memorial and Museum is being paid for by donations from both public and private resources.
The underground PATH train station is being rebuilt under an FTA (Federal Transportation Administration) grant.
Towers Two, Three and Four are being built by Silverstein Properties, Inc., in accordance with his original lease and the Master Agreement. Some of that is being financed by his insurance settlement, but the insurance was not enough to rebuild. He has to get private financing from banks.
Other parts of the project, such as the North Projection connecting the underground PATH station with the World Financial Center under West Street, the Vehicular Security Center beneath the south end of the site where trucks and deliveries will be made, and the installation of the streets are being paid for by the Port Authority, which collects no taxes but makes money from tolls, airport fees, port fees, and rents from stores, etc., at its airports and other facilities.